-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config map nim model name fetch #3276
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
… name to avoid waiting for resource termination after deletion Signed-off-by: Olga Lavtar <olavtar@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3276 +/- ##
==========================================
- Coverage 84.87% 84.81% -0.06%
==========================================
Files 1306 1306
Lines 29196 29207 +11
Branches 7885 7890 +5
==========================================
- Hits 24780 24773 -7
- Misses 4416 4434 +18
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
Retrieving ConfigMap using service account and added ${uid} to PVC name to avoid waiting for resource termination after deletion
How Has This Been Tested?
Tested locally.
Test Impact
Deployed a NIM model, deleted it, and deployed another model while the PVC was still in the 'Terminating' state.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main