Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config map nim model name fetch #3276

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olavtar
Copy link
Contributor

@olavtar olavtar commented Oct 1, 2024

Description

Retrieving ConfigMap using service account and added ${uid} to PVC name to avoid waiting for resource termination after deletion

How Has This Been Tested?

Tested locally.

Test Impact

Deployed a NIM model, deleted it, and deployed another model while the PVC was still in the 'Terminating' state.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Signed-off-by: Olga Lavtar <olavtar@redhat.com>
… name to avoid waiting for resource termination after deletion

Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olavtar olavtar marked this pull request as draft October 1, 2024 01:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (228e221) to head (bc3c9ac).

Files with missing lines Patch % Lines
frontend/src/api/k8s/servingRuntimes.ts 66.66% 5 Missing ⚠️
...rc/pages/modelServing/screens/projects/nimUtils.ts 42.85% 4 Missing ⚠️
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 1 Missing ⚠️
...s/projects/NIMServiceModal/NIMModelListSection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
- Coverage   84.87%   84.81%   -0.06%     
==========================================
  Files        1306     1306              
  Lines       29196    29207      +11     
  Branches     7885     7890       +5     
==========================================
- Hits        24780    24773       -7     
- Misses       4416     4434      +18     
Files with missing lines Coverage Δ
...d/src/pages/modelServing/screens/projects/utils.ts 97.27% <100.00%> (+0.42%) ⬆️
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 4.95% <0.00%> (-1.00%) ⬇️
...s/projects/NIMServiceModal/NIMModelListSection.tsx 1.63% <0.00%> (ø)
...rc/pages/modelServing/screens/projects/nimUtils.ts 52.27% <42.85%> (ø)
frontend/src/api/k8s/servingRuntimes.ts 94.39% <66.66%> (-4.55%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...bc3c9ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant