Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump v1alpha1 to v1 #3463

Closed
wants to merge 1 commit into from
Closed

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Nov 12, 2024

https://issues.redhat.com/browse/RHOAIENG-15234

Description

Reopening this PR
DataSciencePipelineApplicationModels to be bumped to v1

How Has This Been Tested?

  • Adjust the pipeline devFlags to point to main
  • check whether pipeline server created successfully

Test Impact

Updated the mocks to use v1

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gkrumbach07 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 13, 2024

/retest

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 14, 2024

Reopening another pr due to delete quay image issue

@pnaik1 pnaik1 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant