Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support start_time parameter on read_changes #156

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ewanharris
Copy link
Member

Description

Adds the start_time parameter to the read_changes request

References

openfga/sdk-generator#455

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners December 18, 2024 10:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (99f45c7) to head (e56a36f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   68.92%   68.95%   +0.03%     
==========================================
  Files         124      124              
  Lines        9853     9864      +11     
==========================================
+ Hits         6791     6802      +11     
  Misses       3062     3062              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris force-pushed the feat/readchanges-start_time branch from 6a6ebe5 to f785ba6 Compare December 18, 2024 10:48
@ewanharris ewanharris force-pushed the feat/readchanges-start_time branch from f785ba6 to e56a36f Compare December 18, 2024 10:51
@ewanharris ewanharris added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 7af8409 Dec 18, 2024
17 checks passed
@ewanharris ewanharris deleted the feat/readchanges-start_time branch December 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants