Merge pull request #18 from /issues/17

bug: Wrap delete and insert of tags in a transaction
openfoodfacts · Nov 2, 2023 · dae0214 · dae0214
2 parents 0c73b8f + 89392be
commit dae0214
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/src/domain/services/import.service.spec.ts b/src/domain/services/import.service.spec.ts
@@ -50,6 +50,9 @@ function mockMongoDB(productList) {
   mockedProducts = productList;
 }
 
+// Import tests can sometimes take a little time in GitHub
+jest.setTimeout(10000);
+
 describe('importFromMongo', () => {
   it('should import a new product update existing products and delete missing products', async () => {
     await createTestingModule([DomainModule], async (app) => {

diff --git a/src/domain/services/import.service.ts b/src/domain/services/import.service.ts
@@ -167,6 +167,8 @@ export class ImportService {
       // Get the underlying table name for the entity
       const tableName = this.em.getMetadata(entity).tableName;
 
+      await connection.execute('begin');
+
       // Delete existing tags for products that were imorted on this run
       const deleted = await connection.execute(
         `delete from ${tableName} 

diff --git a/src/domain/services/query.service.spec.ts b/src/domain/services/query.service.spec.ts
@@ -14,6 +14,9 @@ import { createTestingModule, randomCode } from '../../../test/test.helper';
 import { UnprocessableEntityException } from '@nestjs/common';
 import { LoadedTag } from '../entities/loaded-tag';
 
+// Tests can sometimes take a little time in GitHub
+jest.setTimeout(10000);
+
 describe('count', () => {
   it('should count the number of products with a tag', async () => {
     await createTestingModule([DomainModule], async (app) => {