Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from ofVec3f to glm #300

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edap
Copy link
Member

@edap edap commented Jan 8, 2019

Main changes:

  • Add a missing image
  • Remove part regarding operator overloading for vector operations
  • change from ofVec* to glm::vec*
  • update quaternion and vector operation function with the glm ones

Regarding:

/* From-To Rotations */
void ofQuaternion::makeRotate(const ofVec3f& vec1, const ofVec3f& vec2);

I have removed it because in glm there is not a function out of the box to do this. Although we could implement it, look at http://www.opengl-tutorial.org/intermediate-tutorials/tutorial-17-quaternions/ and “RotationBetweenVectors”. In case it is something that we would like to have, i can make a PR for adding this function, that it is pretty useful (I have tested the exact snipper in my own projects).

@edap
Copy link
Member Author

edap commented Jan 8, 2019

@OmerShapira it would be nice if you can have a look ;)

@edap
Copy link
Member Author

edap commented Jan 9, 2019

Also, the format of the formula it is broken since a while now. @OmerShapira Which tool did you use to format it? is it possible for you to fix it? otherwise I think it make sense to remove it.

@edap
Copy link
Member Author

edap commented Feb 17, 2019

ping @OmerShapira

@edap
Copy link
Member Author

edap commented Feb 20, 2019

I think it makes sense to remove the broken formulas. @arturoc ?

@edap
Copy link
Member Author

edap commented Feb 27, 2019

the syntax highlighting error is related to #291.
I think that apart this issue, that is already tracked n 291, the chapter is up to date with the current OF version.

@ofZach
Copy link
Contributor

ofZach commented Feb 27, 2019

the rendering issue is server side I'd wager... I seem to remember that certain packages are needed. I would guess running the script that builds the book would give some insight

@arturoc
Copy link
Member

arturoc commented Feb 27, 2019

@edap I think what we could do is leave this document as it is and add your modifications as a new one + a note at the beginning of this one explaining that since 0.10 OF uses glm instead of our own implementation of vector math. There's still a lot of projects and addons that use ofVec so i think it would be a good idea to keep both versions around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants