Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer sidebar: Support search for Blockly rules/scripts #1946

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Jun 29, 2023

Closes #1943.

Searches for 'block', 'blockly', 'blocksource' (case is ignored) will return a list of all Blockly rules.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner June 29, 2023 09:41
@relativeci
Copy link

relativeci bot commented Jun 29, 2023

Job #1047: Bundle Size — 15.74MiB (~+0.01%).

3a8571a(current) vs 6ae772e main#1046(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #1047
     Baseline
Job #1046
Initial JS 1.67MiB(~+0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.98%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1047
     Baseline
Job #1046
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~+0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1047 reportView main branch activity

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added this to the 4.0 milestone Jun 29, 2023
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 29, 2023
@florian-h05 florian-h05 changed the title [mainui] search for Blockly with developer tools search Developer sidebar: Support search for Blockly rules/scripts Jun 29, 2023
@florian-h05
Copy link
Contributor

florian-h05 commented Jun 29, 2023

Can you please open a PR for the docs? You‘ll find the edit this page link at the bottom of this page: https://next.openhab.org/docs/tutorial/tips-and-tricks.html#search. And when your are at it: Can you please also update these docs for #1876?

I‘ll merge this when CI passed.

@florian-h05 florian-h05 merged commit 7ee9e03 into openhab:main Jun 29, 2023
4 checks passed
@mherwege mherwege deleted the search_blockly branch June 29, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mainui] Ability to filter rules by script type
2 participants