Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer sidebar: Support search for rule tags #1947

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mherwege
Copy link
Contributor

It is possible to filter the rules on tags in the search bar of the rule list, as they are visible on screen. As items can be searched by tag in the developer toolbar search, I think it is still useful to extend the rule search in the developer toolbar to tags as well. I tend to give my rules tags, often corresponding to tags on items as well. This allows finding all of these in one place.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner June 29, 2023 12:05
@relativeci
Copy link

relativeci bot commented Jun 29, 2023

Job #1048: Bundle Size — 15.74MiB (~+0.01%).

a4c7d6c(current) vs 3a8571a main#1047(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1048
     Baseline
Job #1047
Initial JS 1.67MiB(~+0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1048
     Baseline
Job #1047
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~+0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1048 reportView main branch activity

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also thanks for fixing the comment.

@florian-h05 florian-h05 changed the title [mainui] Developer search bar, search rule tags Developer sidebarbar: Support search for rule tags Jun 29, 2023
@florian-h05 florian-h05 changed the title Developer sidebarbar: Support search for rule tags Developer sidebar: Support search for rule tags Jun 29, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Jun 29, 2023
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 29, 2023
@florian-h05 florian-h05 merged commit 1f659cc into openhab:main Jun 29, 2023
4 checks passed
@mherwege mherwege deleted the search_rule_tags branch July 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants