Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockly] Add context block typing & Extend Qty block var type support #1948

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[blockly] Add context block typing & Extend Qty block var type support #1948

merged 1 commit into from
Jul 10, 2023

Conversation

stefan-hoehn
Copy link
Contributor

@stefan-hoehn stefan-hoehn commented Jul 2, 2023 •
edited by florian-h05
Loading

Fixes #1942.
Requires version 4.5.0 of openhab-js, therefore awaiting openhab/openhab-addons#15219.

  • Adds context block typings.
  • Adds supports for Item state input in addition to Item object only in case Qty Block has a var as input.

@stefan-hoehn
context block typing, extended QTY var type supÃport
67f9a87 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner July 2, 2023 11:02
@stefan-hoehn stefan-hoehn changed the title context block typing, extended QTY var type supÃport context block typing, extended QTY var type support Jul 2, 2023
@stefan-hoehn stefan-hoehn changed the title context block typing, extended QTY var type support context block typing, extended Qty block var type support Jul 2, 2023
@relativeci
Copy link

relativeci bot commented Jul 2, 2023

Job #1049: Bundle Size — 15.74MiB (~+0.01%).

05e622a(current) vs a4c7d6c main#1048(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (no changes)
                 Current
Job #1049		      Baseline
Job #1048
Initial JS 1.67MiB 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1049		      Baseline
Job #1048
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~+0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1049 report View main branch activity

@florian-h05
Copy link
Contributor

I will review this once I have released the new required version and it is included in the addon.

florian-h05
florian-h05 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let‘s wait for the merge of openhab/openhab-addons#15219.

@florian-h05 florian-h05 merged commit 851bd50 into openhab:main Jul 10, 2023
4 checks passed
@florian-h05 florian-h05 deleted the blockly_fix_context_block branch July 10, 2023 21:20
@florian-h05 florian-h05 changed the title context block typing, extended Qty block var type support [blockly] Add context block typing & Extend Qty block var type support Jul 10, 2023
@florian-h05 florian-h05 added the enhancement New feature or request label Jul 10, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Jul 10, 2023
@florian-h05 florian-h05 added the main ui Main UI label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[blockly] contextual info new state of item cannot be interpreted as QuantityType
2 participants
@stefan-hoehn @florian-h05