Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally align smart-select value with other input values #2356

Closed
wants to merge 1 commit into from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 15, 2024

Related to #2326
@florian-h05
This will make all of the smart-selects aligned the same way without needing to add special class to each element

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 15, 2024 18:31
Copy link

relativeci bot commented Feb 15, 2024

Job #1542: Bundle Size — 11.01MiB (~-0.01%).

7d31119(current) vs e3fae0b main#1540(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #1542
     Baseline
Job #1540
No change  Initial JS 1.84MiB 1.84MiB
Regression  Initial CSS 607.96KiB(+0.04%) 607.73KiB
Change  Cache Invalidation 22.94% 17.34%
No change  Chunks 220 220
No change  Assets 242 242
Change  Modules 3079(+0.03%) 3078
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1542
     Baseline
Job #1540
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Regression  CSS 889.37KiB (~+0.01%) 889.3KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1542 reportView jimtng:align-smart-select-global... branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I’m hesitant whether we want to do that.
Before doing that, I’d like to check where and how the smart select is used in the UI, i.e. check these search results: https://github.com/search?q=repo%3Aopenhab%2Fopenhab-webui+Smart-select+language%3AVue&type=code&l=Vue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghys
Copy link
Member

ghys commented Feb 15, 2024

In general I’m hesitant whether we want to do that.

We don't. I'm shutting this down before it gets to a point where it's just "we accept it because of all the work".
The smart selects are fine as they are.

@ghys ghys closed this Feb 15, 2024
@jimtng jimtng deleted the align-smart-select-globally branch February 18, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants