Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to addons store #2396

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 23, 2024

To match changes in #2381

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 23, 2024 08:28
Copy link

relativeci bot commented Feb 23, 2024

Job #1637: Bundle Size — 11.01MiB (~+0.01%).

db4efc0(current) vs 6b7e1c4 main#1636(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1637
     Baseline
Job #1636
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.89KiB 607.89KiB
Change  Cache Invalidation 17.61% 23.27%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3087 3087
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1637
     Baseline
Job #1636
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 889.44KiB 889.44KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1637 reportView jimtng:update-addons-links branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything left in the UI?

@florian-h05 florian-h05 merged commit e229246 into openhab:main Feb 23, 2024
6 checks passed
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 23, 2024
@jimtng
Copy link
Contributor Author

jimtng commented Feb 23, 2024

Anything left in the UI?

This is what I've found (so far).

@jimtng jimtng deleted the update-addons-links branch February 23, 2024 09:40
@florian-h05
Copy link
Contributor

Before merging I also checked, and I did not find any more.

seime pushed a commit to seime/openhab-webui that referenced this pull request Mar 16, 2024
To match changes in openhab#2383.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants