Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script Editor: Fix script loading #2442

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Script Editor: Fix script loading #2442

merged 1 commit into from
Mar 3, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 3, 2024 •
edited
Loading

Regression from #2374

The problem is when I clicked on a file-based script in the UI, the content of the script didn't load.

Before:
image

After:
image

@jimtng
Script Editor: Fix script loading
953b736 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner March 3, 2024 09:26
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 3, 2024

Job #1762: Bundle Size — 11.13MiB (~-0.01%).

953b736(current) vs 61aa3d8 main#1761(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1762		      Baseline
Job #1761
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 16.75% 17.37%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3091 3091
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1762		      Baseline
Job #1761
Improvement  JS 9.31MiB (~-0.01%) 9.31MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1762 report View jimtng:fix-script-loading branch activity View project dashboard

@jimtng
Copy link
Contributor Author

jimtng commented Mar 3, 2024

@florian-h05 @kaikreuzer this fixed a recent regression, hopefully this makes it into M1

@florian-h05
Copy link
Contributor

I am not at home today, so @kaikreuzer or @ghys would have to review this.

kaikreuzer
kaikreuzer approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 0f343f3 into openhab:main Mar 3, 2024
6 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Mar 3, 2024
@kaikreuzer kaikreuzer added bug Something isn't working regression labels Mar 3, 2024
@jimtng jimtng deleted the fix-script-loading branch March 3, 2024 13:09
@florian-h05 florian-h05 added the main ui Main UI label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jimtng @florian-h05 @kaikreuzer