Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MAUI android sample #2200

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gentledepp
Copy link

@gentledepp gentledepp commented Oct 7, 2024

I added the android part of the OpenIddict.Sandbox.Maui.Client

What may be missing is

  • add a readme to maui describing how to get the sample to run on iOS and Android (i.e. use dev tunnel and do not use developmentcertificates)
    Shall I add that too?

Also, I added a progress dialog with a "cancel" button, as it was confusing to see the buttons to just be disabled.
In case anything goes wrong on the server side you could not cancel the login process, but had to restart the app. 😐

It is rough, but functional. Check it out:

mt-erber_deeplink

@kevinchalet
Copy link
Member

Note: not adding Android to that sample was deliberate: the Android tooling is bugged and prevents the project from building correctly on my machine (probably caused by the diacritics in my Windows user folder name). I'm of course not against merging this PR, but the underlying issue will first need to be fixed by the Android folks.

@gentledepp
Copy link
Author

No problem. I am not in a hurry with this.
Merge it as soon or late as you want.

I used this as an exercise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants