Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: if status any do not pass filter on status #12

Merged
merged 3 commits into from
Dec 13, 2023
Merged

hotfix: if status any do not pass filter on status #12

merged 3 commits into from
Dec 13, 2023

Conversation

olewandowski1
Copy link
Collaborator

HOTFIX: Do not pass filter if status is null (means Any). This returns all available vouchers.

malinowskikam
malinowskikam approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@malinowskikam malinowskikam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olewandowski1 olewandowski1 marked this pull request as draft December 13, 2023 12:06
@olewandowski1 olewandowski1 marked this pull request as ready for review December 13, 2023 12:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@malinowskikam malinowskikam merged commit e2176a7 into develop Dec 13, 2023
4 checks passed
@malinowskikam malinowskikam deleted the hotfix/voucher-filters branch December 13, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinowskikam malinowskikam malinowskikam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olewandowski1 @malinowskikam