Merge pull request #123 from openimis/feature/OP-1847

OP-1847: improve modules js generation
openimis · Mar 22, 2024 · 2cccd38 · 2cccd38
2 parents 620c2b5 + e22059d
commit 2cccd38
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 18 deletions.
diff --git a/modules-config.js b/modules-config.js
@@ -45,15 +45,21 @@ export const packages = [
 `);
 
   stream.write(`
-export function loadModules (cfg = {}) {
-  return [
-    ${modules
-      .map(
-        ({ name, logicalName, moduleName }) =>
-          `require("${moduleName}").${name ?? "default"}(cfg["${logicalName}"] || {})`,
-      )
-      .join(",\n    ")}
-  ];\n
+export function loadModules(cfg = {}) {
+  const loadedModules = [];
+${modules
+.map(({ name, logicalName, moduleName }) => {
+return `
+  try {
+    loadedModules.push(require("${moduleName}").${name ?? "default"}(cfg["${logicalName}"] || {}));
+  } catch (error) {
+    alert(\`Failed to load module "${moduleName}". More details can be found in the developer console. Look for: \${error}\`);
+    console.error(error);
+  }
+`;
+})
+.join("")}
+  return loadedModules;
 }
 `);
 

diff --git a/openimis-config.js b/openimis-config.js
@@ -45,15 +45,21 @@ export const packages = [
 `);
 
   stream.write(`
-export function loadModules (cfg = {}) {
-  return [
-    ${modules
-      .map(
-        ({ name, logicalName, moduleName }) =>
-          `require("${moduleName}").${name ?? "default"}(cfg["${logicalName}"] || {})`,
-      )
-      .join(",\n    ")}
-  ];\n
+export function loadModules(cfg = {}) {
+  const loadedModules = [];
+${modules
+.map(({ name, logicalName, moduleName }) => {
+return `
+  try {
+    loadedModules.push(require("${moduleName}").${name ?? "default"}(cfg["${logicalName}"] || {}));
+  } catch (error) {
+    alert(\`Failed to load module "${moduleName}". More details can be found in the developer console. Look for: \${error}\`);
+    console.error(error);
+  }
+`;
+})
+.join("")}
+  return loadedModules;
 }
 `);