Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix Local Check Script to Continuously Monitor Docker Start-up a… #200

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Fix: Fix Local Check Script to Continuously Monitor Docker Start-up a… #200

merged 3 commits into from
Sep 12, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Sep 12, 2023 •
edited
Loading

…bout Makefile


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #198

📝 Special notes for your reviewer:

🎯 Describe how to verify it

make check

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw cubxxw requested a review from a team as a code owner September 12, 2023 02:08
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2023
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2023
@cubxxw cubxxw temporarily deployed to openim September 12, 2023 02:16 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim September 12, 2023 02:16 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim September 12, 2023 02:16 — with GitHub Actions Inactive
cubxxw
cubxxw commented Sep 12, 2023
View reviewed changes
Copy link
Contributor Author

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@kubbot kubbot enabled auto-merge September 12, 2023 11:54
@kubbot kubbot added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit cc1c5ff Sep 12, 2023
11 checks passed
@kubbot kubbot deleted the kind/check-1 branch September 12, 2023 12:52
@openimsdk openimsdk locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kubbot kubbot kubbot approved these changes

@skiffer-git skiffer-git skiffer-git approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Local Check Script to Continuously Monitor Docker Start-up
4 participants
@cubxxw @FGadvancer @skiffer-git @kubbot