Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make listening only after connection to components prepared #214

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat: make listening only after connection to components prepared #214

merged 2 commits into from
Sep 20, 2023

Conversation

CNCSMonster
Copy link
Contributor

@CNCSMonster CNCSMonster requested review from cubxxw and a team as code owners September 18, 2023 09:48
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 18, 2023 •
edited
Loading

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

@CNCSMonster
Copy link
Contributor Author

waiting

@CNCSMonster CNCSMonster temporarily deployed to openim September 19, 2023 06:29 — with GitHub Actions Inactive
@CNCSMonster CNCSMonster temporarily deployed to openim September 19, 2023 06:29 — with GitHub Actions Inactive
@CNCSMonster CNCSMonster temporarily deployed to openim September 19, 2023 06:29 — with GitHub Actions Inactive
@CNCSMonster
Copy link
Contributor Author

yes,i agrre with cla

@CNCSMonster
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Sep 19, 2023
@openimbot
@CNCSMonster has signed the CLA in openimsdk/chat#214
5e7167b
@CNCSMonster
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

skiffer-git
skiffer-git approved these changes Sep 19, 2023
View reviewed changes
pkg/common/chatrpcstart/start.go Outdated
@@ -62,5 +58,10 @@ func Start(rpcPort int, rpcRegisterName string, prometheusPort int, rpcFn func(c
if err != nil {
return utils.Wrap1(err)
}
listener, err := net.Listen("tcp", net.JoinHostPort(network.GetListenIP(config.Config.Rpc.ListenIP), strconv.Itoa(rpcPort)))
if err != nil {
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.Wrap1(err)

@CNCSMonster CNCSMonster temporarily deployed to openim September 20, 2023 06:48 — with GitHub Actions Inactive
@CNCSMonster CNCSMonster temporarily deployed to openim September 20, 2023 06:48 — with GitHub Actions Inactive
@CNCSMonster CNCSMonster temporarily deployed to openim September 20, 2023 06:48 — with GitHub Actions Inactive
@cubxxw cubxxw added this pull request to the merge queue Sep 20, 2023
Merged via the queue into openimsdk:main with commit 99834ac Sep 20, 2023
13 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Sep 20, 2023
@cubxxw cubxxw linked an issue Sep 30, 2023 that may be closed by this pull request
Feature: listen after connecting to components #210
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git skiffer-git approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: listen after connecting to components
4 participants
@CNCSMonster @kubbot @skiffer-git @cubxxw