Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: super openim chat k8s deployment and code remould #240

Merged
merged 24 commits into from
Nov 7, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Oct 24, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

This PR introduces a clustered deployment configuration for OpenIM Chat, which includes necessary code adjustments, scripts for automation, and a design for Helm Charts. These changes aim to improve scalability, operability, and ease of deployment and management on Kubernetes environments.

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

The enhancements proposed in this PR are crucial for deploying OpenIM Chat in larger, distributed environments, ensuring its reliability and fault tolerance. Additionally, the Helm Charts design and scripts will simplify the deployment and management processes, promoting the use of OpenIM Chat in cloud-native setups.

🅰 Which issue(s) this PR fixes:

Fixes #239

📝 Special notes for your reviewer:

This PR includes substantial changes and I've ensured to adhere to the coding standards and testing requirements. I am looking forward to feedback for further improvements.

🎯 Describe how to verify it

After pulling the changes, execute make all locally to run all tests and verify the implementation. Additionally, follow the updated documentation for deploying in a clustered environment and verify the functionality on a Kubernetes cluster.

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw cubxxw requested review from a team as code owners October 24, 2023 02:38
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2023
@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@cubxxw cubxxw temporarily deployed to openim October 24, 2023 02:38 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 24, 2023 02:38 — with GitHub Actions Inactive
@kubbot
Copy link
Contributor

kubbot commented Oct 24, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

@cubxxw cubxxw temporarily deployed to openim October 24, 2023 02:38 — with GitHub Actions Inactive
@sweep-ai
Copy link

sweep-ai bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

lin.huang and others added 13 commits October 26, 2023 03:49
…istration logic,modify config file reading logic
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:18 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:18 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:18 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:19 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:19 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 26, 2023 10:19 — with GitHub Actions Inactive
withchao
withchao previously approved these changes Oct 26, 2023
@luhaoling
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@luhaoling
Copy link
Contributor

recheck

@luhaoling
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@xuexihuang
Copy link
Contributor

xuexihuang commented Nov 7, 2023

I have read the CLA Document and I hereby sign the CLA

@cubxxw
Copy link
Contributor Author

cubxxw commented Nov 7, 2023

recheck

openimbot added a commit to openim-sigs/cla that referenced this pull request Nov 7, 2023
@kubbot kubbot added this pull request to the merge queue Nov 7, 2023
Merged via the queue into openimsdk:main with commit 9d43247 Nov 7, 2023
10 of 11 checks passed
@cubxxw cubxxw deleted the feat/super-k8s branch November 7, 2023 10:35
@openimsdk openimsdk locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Clustered Deployment, Code Adjustments, Scripts, and Helm Charts Design for OpenIM Chat
7 participants