-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crr is stuck when multi crrs specify same pod together #1653
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: joey <zchengjoey@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also, is it possible to modify the webhook to directly reject requests when there is a running crr processing the same pod? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
+ Coverage 47.91% 49.46% +1.54%
==========================================
Files 162 183 +21
Lines 23491 18997 -4494
==========================================
- Hits 11256 9396 -1860
+ Misses 11014 8378 -2636
- Partials 1221 1223 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@chengjoey agree. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
fix crr is stuck when multi crrs specify same pod together #1626
when multi crrs specify same pod at the same time, only one will be enqueue
kruise/pkg/daemon/containerrecreate/crr_daemon_controller.go
Lines 160 to 162 in 8ae13b1
The original logic may be designed this way intentionally, but would it be better to use
${namespace}/${crdName}
as the key?Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews