-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SidecarSet add upgrade state in pod annotation (#1312) #1664
base: master
Are you sure you want to change the base?
SidecarSet add upgrade state in pod annotation (#1312) #1664
Conversation
Welcome @LvWuqian! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
+ Coverage 47.91% 48.88% +0.96%
==========================================
Files 162 188 +26
Lines 23491 19331 -4160
==========================================
- Hits 11256 9449 -1807
+ Misses 11014 8648 -2366
- Partials 1221 1234 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign furykerry |
a05cc8b
to
50203f9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign zmberg |
@LvWuqian: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ⅰ. Describe what this PR does
SidecarSet add upgrade state in pod annotation
Ⅱ. Does this pull request fix one issue?
fixes #1312
Ⅲ. Describe how to verify it
Update SidecarSet in batches, modifies the images, and monitors the state changes of the corresponding SidecarSet in the annotation "kruise.io/sidecarset-hash". It will first change to "Updating" and then change to "Normal".
Ⅳ. Special notes for reviews