Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidecarSet add upgrade state in pod annotation (#1312) #1664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LvWuqian
Copy link

Ⅰ. Describe what this PR does

SidecarSet add upgrade state in pod annotation

Ⅱ. Does this pull request fix one issue?

fixes #1312

Ⅲ. Describe how to verify it

Update SidecarSet in batches, modifies the images, and monitors the state changes of the corresponding SidecarSet in the annotation "kruise.io/sidecarset-hash". It will first change to "Updating" and then change to "Normal".

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

Welcome @LvWuqian! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.

Project coverage is 48.88%. Comparing base (0d0031a) to head (50203f9).
Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/sidecarset/sidecarset_processor.go 58.33% 7 Missing and 3 partials ⚠️
pkg/control/sidecarcontrol/util.go 66.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
+ Coverage   47.91%   48.88%   +0.96%     
==========================================
  Files         162      188      +26     
  Lines       23491    19331    -4160     
==========================================
- Hits        11256     9449    -1807     
+ Misses      11014     8648    -2366     
- Partials     1221     1234      +13     
Flag Coverage Δ
unittests 48.88% <63.04%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LvWuqian
Copy link
Author

/assign furykerry

@zmberg zmberg added this to the 1.7 milestone Jul 25, 2024
pkg/control/sidecarcontrol/util.go Outdated Show resolved Hide resolved
pkg/control/sidecarcontrol/util.go Outdated Show resolved Hide resolved
pkg/controller/sidecarset/sidecarset_processor.go Outdated Show resolved Hide resolved
@zmberg zmberg removed this from the 1.7 milestone Jul 30, 2024
@LvWuqian LvWuqian force-pushed the SidecarSet-add-upgrade-state-in-pod-annotation branch from a05cc8b to 50203f9 Compare August 4, 2024 16:06
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from furykerry by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LvWuqian
Copy link
Author

LvWuqian commented Aug 4, 2024

/assign zmberg

@kruise-bot
Copy link

@LvWuqian: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] SidecarSet add upgrade state in pod annotation
4 participants