Properly handle spectating when a player disconnects #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should now fully fix #735 and also make |
ksenonadv
reviewed
Oct 13, 2023
| // Related issue: https://github.com/openmultiplayer/open.mp/issues/735 | ||
| // Disable spectator's spectating state when spectated player is disconnected | ||
| // This also makes spectateData values to be accurate and not remain with old data | ||
| if (other->spectateData_.type == PlayerSpectateData::ESpectateType::Player && other->spectateData_.spectateID == player.getID()) |
There was a problem hiding this comment.
We should do this for vehicles as well.
ksenonadv
approved these changes
Oct 13, 2023
Vince0789
reviewed
Oct 14, 2023
ksenonadv
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.