Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return 130 rpc, if player have a bad name #900

Closed
wants to merge 1 commit into from

Conversation

atomlin-git
Copy link
Contributor

fix issue #738

Hual
Hual previously approved these changes Mar 29, 2024
@Hual
Copy link
Collaborator

Hual commented Mar 29, 2024

While this change makes sense I don't see how it would actually fix the linked issue

@Hual Hual self-requested a review March 29, 2024 09:49
@Hual Hual dismissed their stale review March 29, 2024 09:50

don't think it fixes issue

@atomlin-git
Copy link
Contributor Author

RPC simply does not have time to reach the player

With out changes:
image

With changes:
image

@Hual
Copy link
Collaborator

Hual commented Mar 31, 2024

RPC simply does not have time to reach the player

With out changes: image

With changes: image

But isn't the player being kicked right after that in another function?

@atomlin-git
Copy link
Contributor Author

More better solution in #906

@atomlin-git atomlin-git closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants