NPC Component (WIP) #916

AmyrAhmady · 2024-04-17T02:58:47Z

Info

This PR is made to follow progress of NPC component development
Also creating this PR allows our build CIs to run so people can grab server builds from this PR to test NPCs

(Note: Some stuff are taken from this branch https://github.com/openmultiplayer/open.mp/tree/Alasnkz/npc like NPC network class and some move calculations)

Current Pawn scripting API

Natives:

native NPC_Create(const name[]);
native NPC_Destroy(npcid);
native NPC_IsValid(npcid);
native NPC_Spawn(npcid);
native NPC_SetPos(npcid, Float:x, Float:y, Float:z);
native NPC_GetPos(npcid, &Float:x, &Float:y, &Float:z);
native NPC_SetRot(npcid, Float:x, Float:y, Float:z);
native NPC_GetRot(npcid, &Float:x, &Float:y, &Float:z);
native NPC_SetFacingAngle(npcid, Float:angle);
native NPC_GetFacingAngle(npcid, &Float:angle);
native NPC_SetVirtualWorld(npcid, vw);
native NPC_GetVirtualWorld(npcid, &vw);
native NPC_Move(npcid, Float:x, Float:y, Float:z, moveType);
native NPC_StopMove(npcid);
native NPC_SetSkin(npcid, model);
native NPC_IsStreamedIn(npcid, playerid);
native NPC_IsAnyStreamedIn(npcid);
native NPC_GetAll(npcs[], sizeof npcs);
native NPC_SetInterior(npcid, interiorid);
native NPC_GetInterior(npcid);
native NPC_SetHealth(npcid, Float:health);
native Float:NPC_GetHealth(npcid);
native NPC_SetArmour(npcid, Float:armour);
native Float:NPC_GetArmour(npcid);
native NPC_ApplyAnimation(npcid, const animLib[], const animName[], Float:delta, bool:loop, bool:lockX, bool:lockY, bool:freeze, time, sync);

Callbacks:

forward OnNPCFinishMove(npcid);
forward OnNPCCreate(npcid);
forward OnNPCDestroy(npcid);

Videos:

Short video of basic usage:
https://cdn.discordapp.com/attachments/966398440051445790/1229681168878669895/ompnpc.mp4

eakwarp · 2024-04-17T08:39:24Z

Good job!
I'll try this on my walking npcs)

eakwarp · 2024-04-17T08:50:53Z

native NPC_StopMove(npcid, Float:x, Float:y, Float:z, moveType);


SCRIPT_API(NPC_StopMove, bool(INPC& npc))
{
	npc.stopMove();
	return true;
}

error in native?

ksenonadv · 2024-04-17T08:51:33Z

native NPC_StopMove(npcid, Float:x, Float:y, Float:z, moveType);
SCRIPT_API(NPC_StopMove, bool(INPC& npc))
{
	npc.stopMove();
	return true;
}
error in native?

Edited.

eakwarp · 2024-04-17T10:04:39Z

[2024-04-17T13:02:50+0300] [Info] [connection] incoming connection: 7f00:1:a4ff:ffff:a4ff:ffff:b94b:d7f7:63392 id: 0
[2024-04-17T13:02:50+0300] [Info] WalkNPC 0 Load, skin 31 node 2245
[2024-04-17T13:02:50+0300] [Info] [npc:part] FortCarson has left the server (0:2)
[2024-04-17T13:02:50+0300] [Info] [debug] Server crashed due to an unknown error

The first tests look interesting))

eakwarp · 2024-04-17T10:26:38Z

not bad not bad.)) 500 npc slots, 50 player slots))
Server crashed when i try to spawn npc in OnNPCConnect.

AmyrAhmady · 2024-04-17T10:36:27Z

I don't think NPCs are supposed to connect with ipv6 as your logs show
Also can you try using a cmd instead of spawning on connect? just to see if they work?

AmyrAhmady · 2024-04-17T10:40:48Z

not bad not bad.)) 500 npc slots, 50 player slots)) Server crashed when i try to spawn npc in OnNPCConnect.

Also, update your launcher!

eakwarp · 2024-04-17T10:51:39Z

I don't think NPCs are supposed to connect with ipv6 as your logs show Also can you try using a cmd instead of spawning on connect? just to see if they work?

I removed the spawn, the server is working, the npcs have connected, but are physically absent)

logs looks like good.

....
[2024-04-17T13:43:01+0300] [Info] [connection] incoming connection: 127.0.0.1:60194 id: 354
[2024-04-17T13:43:01+0300] [Info] [npc:join] FortCarson15 has joined the server (354:127.0.0.1)
[2024-04-17T13:43:01+0300] [Info] WalkNPC 355 Load, skin 191 node 4180
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:55540 id: 355
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson16 has joined the server (355:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 356 Load, skin 226 node 4178
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:54902 id: 356
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson17 has joined the server (356:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 357 Load, skin 248 node 4192
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:53290 id: 357
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson18 has joined the server (357:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 358 Load, skin 261 node 4190
[2024-04-17T13:43:03+0300] [Info] [connection] incoming connection: 127.0.0.1:62594 id: 358
[2024-04-17T13:43:03+0300] [Info] [npc:join] FortCarson19 has joined the server (358:127.0.0.1)
[2024-04-17T13:43:03+0300] [Info] WalkNPC 359 Load, skin 151 node 4166
[2024-04-17T13:43:03+0300] [Info] [connection] incoming connection: 127.0.0.1:49694 id: 359
[2024-04-17T13:43:03+0300] [Info] [npc:join] Civilian has joined the server (359:127.0.0.1)
[2024-04-17T13:43:03+0300] [Info] WalkNPC 362 Load, skin 35 node 4218
....

Also, update your launcher!

later )

ipv6

ipv6 turns into a localhost after the first player connects, hm..)

[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: 7f00:1:fcdb:afff:7ce0:afff:9db:afff:58068 id: 55
[2024-04-17T13:41:29+0300] [Info] [npc:join] WillowField4 has joined the server (55:7f00:1:fcdb:afff:7ce0:afff:9db:afff)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 55 Load, skin 48 node 510
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: **7f00:1:fcdb:afff:7ce0:afff:9db:afff:56960 id: 56**
[2024-04-17T13:41:29+0300] [Info] [npc:join] SanPedro5 has joined the server (56:7f00:1:fcdb:afff:7ce0:afff:9db:afff)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 56 Load, skin 236 node 520
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: [censored]:14169 id: 57
**[2024-04-17T13:41:29+0300] [Info] [join] Richard_Castle has joined the server (57:[censored])**
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: **127.0.0.1:61243 id: 58**
[2024-04-17T13:41:29+0300] [Info] [npc:join] SanPedro6 has joined the server (58:127.0.0.1)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 57 Load, skin 192 node 530
[2024-04-17T13:41:30+0300] [Info] [connection] incoming connection: 127.0.0.1:62777 id: 59
[2024-04-17T13:41:30+0300] [Info] [npc:join] SanPedro7 has joined the server (59:127.0.0.1)
[2024-04-17T13:41:30+0300] [Info] WalkNPC 58 Load, skin 190 node 540
[2024-04-17T13:41:30+0300] [Info] [connection] incoming connection: 127.0.0.1:54810 id: 60
[2024-04-17T13:41:30+0300] [Info] [npc:join] SanPedro8 has joined the server (60:127.0.0.1)

eakwarp · 2024-04-17T11:06:03Z

[2024-04-17T14:04:29+0300] [Info] npc 0 spawned via timer
[2024-04-17T14:04:29+0300] [Info] npc 0 walk start timer
[2024-04-17T14:04:29+0300] [Info] [npc:part] FortCarson has left the server (0:2)
[2024-04-17T14:04:29+0300] [Info] [debug] Server crashed due to an unknown error

I tried to spawn NPCs 10 seconds after connecting - the server also crashed

eakwarp · 2024-04-17T11:27:57Z

One more bug, in OnNPCConnect(npcid)
npcid always 0

AmyrAhmady · 2024-04-20T10:07:23Z

As we talked in discord, regarding the crash issue, it should be fixed now. @eakwarp was kicking them and kicking an NPC wasn't implemented since it was on network level. Also removing/destroying NPCs on connect callbacks would result into crashes as well, which is now fixed too.

Also callback names are updated

eakwarp · 2024-08-08T22:13:47Z

what about new builds?)

AmyrAhmady · 2024-10-20T03:00:10Z

AmyrAhmady added the draft label Apr 17, 2024

AmyrAhmady self-assigned this Apr 17, 2024

AmyrAhmady changed the title ~~NPC Component~~ NPC Component (WIP) Apr 17, 2024

AmyrAhmady force-pushed the amir/NPCs branch from b0ca100 to 612341a Compare April 23, 2024 12:01

AmyrAhmady force-pushed the amir/NPCs branch from ccec7a7 to 700d2fe Compare October 18, 2024 05:13

AmyrAhmady added 13 commits October 18, 2024 08:53

continue onReceive event calls if Recording component has failure

4377835

create NPCs component

e930b1c

create pawn scripting api for current NPC functions

949a40e

force internal updates on position and rotation change

1d9bac3

calculate travelled distance once

32331ff

add NPC_StopMove

3e9a7bc

restart npc move when pos or rot is reset

a265c88

only start npc move if move type is valid

43e64cd

set internal rot and pos values during move to avoid recursion

8cb4005

use stopMove when npc move is finished

c1db6c9

only send NPC foot sync if player is spawned

6582920

use underscore suffixed class variables for NPC class

589a6cf

fix formatting

07b1d16

AmyrAhmady added 16 commits October 18, 2024 08:53

rename npc connect events to entity create and destroy

6ee33c1

mark to be destroyed npcs to be process next tick

3417285

destroy NPCs safely

95d5522

use NPC ref instead of ptr in emulate functions

de9320f

store footSyncRate config value in npc component

4c7916c

calculate estimated arrival time and use it to detect finish move

2b94508

fix velocity calculation

84b176c

add NPC_SetFacingAngle and GetFacingAngle

827d3e6

another attempt to fix npc movements

c474539

add NPC_SetSkin

13daf56

add streamed in check natives for NPCs

7c369e8

add NPC_GetAll native

e686725

npc interior natives

10599d5

proper class variable initialization in constructor

eb1a3f4

add set/get velocity for NPCs

4bf88e5

fix build

5ad4db9

AmyrAhmady force-pushed the amir/NPCs branch from 7d97857 to 5ad4db9 Compare October 18, 2024 05:23

fix NPC_SetFacingAngle

5980d0f

AmyrAhmady added 2 commits October 20, 2024 06:57

add health, armour and animation natives

3e101db

validity check for setHealth and setArmour

0ee0f1a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPC Component (WIP) #916

NPC Component (WIP) #916

AmyrAhmady commented Apr 17, 2024 •

edited

Loading

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

ksenonadv commented Apr 17, 2024

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

AmyrAhmady commented Apr 17, 2024

AmyrAhmady commented Apr 17, 2024

eakwarp commented Apr 17, 2024 •

edited

Loading

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

AmyrAhmady commented Apr 20, 2024

eakwarp commented Aug 8, 2024

AmyrAhmady commented Oct 20, 2024 •

edited

Loading

NPC Component (WIP) #916

Are you sure you want to change the base?

NPC Component (WIP) #916

Conversation

AmyrAhmady commented Apr 17, 2024 • edited Loading

Info

Current Pawn scripting API

Natives:

Callbacks:

Videos:

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

ksenonadv commented Apr 17, 2024

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

AmyrAhmady commented Apr 17, 2024

AmyrAhmady commented Apr 17, 2024

eakwarp commented Apr 17, 2024 • edited Loading

eakwarp commented Apr 17, 2024

eakwarp commented Apr 17, 2024

AmyrAhmady commented Apr 20, 2024

eakwarp commented Aug 8, 2024

AmyrAhmady commented Oct 20, 2024 • edited Loading

AmyrAhmady commented Apr 17, 2024 •

edited

Loading

eakwarp commented Apr 17, 2024 •

edited

Loading

AmyrAhmady commented Oct 20, 2024 •

edited

Loading