Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Budget of Concept #88

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Update Budget of Concept #88

merged 7 commits into from
Jan 30, 2024

Conversation

ccrock4t
Copy link
Collaborator

This PR updates the Budget of Concept based on the rules specified in the technical design (solving issues #67 , #68 , #71 )

@ccrock4t ccrock4t marked this pull request as ready for review January 17, 2024 19:40
@ccrock4t ccrock4t requested review from maxeeem and bowen-xu January 17, 2024 19:40
@ccrock4t
Copy link
Collaborator Author

There appears to be a bug in dev branch, that when the budget of item is updated, its corresponding level in Bag its not updated. Maybe it can be fixed here?

@ccrock4t
Copy link
Collaborator Author

Nevermind, the bug is a consequence of this PR

@ccrock4t ccrock4t marked this pull request as draft January 18, 2024 10:43
@ccrock4t ccrock4t marked this pull request as ready for review January 18, 2024 20:50
Copy link
Collaborator

@maxeeem maxeeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr looks good, I do not see any issues. 👍

Side note: In the future we may want to revisit other code in this file. There may be some improvements we can make for readability and efficiency. For example, Concept._conceptualize which is called in both _build_task_links and _build_term_links already performs take and put on a concept which is then also done inside the update_* functions. It may be that keeping them separate is what we want, or we may look for ways to combine some operations avoiding unnecessary reads and writes.

@bowen-xu bowen-xu merged commit 5cab9f4 into dev Jan 30, 2024
1 check failed
@ccrock4t ccrock4t deleted the update_concept_budget branch January 30, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants