-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Budget of Concept #88
Conversation
…whenever a judgment is accepted
There appears to be a bug in |
Nevermind, the bug is a consequence of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr looks good, I do not see any issues. 👍
Side note: In the future we may want to revisit other code in this file. There may be some improvements we can make for readability and efficiency. For example, Concept._conceptualize
which is called in both _build_task_links
and _build_term_links
already performs take
and put
on a concept which is then also done inside the update_*
functions. It may be that keeping them separate is what we want, or we may look for ways to combine some operations avoiding unnecessary reads and writes.
This PR updates the Budget of Concept based on the rules specified in the technical design (solving issues #67 , #68 , #71 )