Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/google drive #8

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

midepeter
Copy link

I made this initial push for the google drive feature.

@midepeter midepeter changed the title google drive feature feat/google drive Jan 8, 2023
@opensaucerer
Copy link
Collaborator

opensaucerer commented Jan 8, 2023

Thank you very much for this @midepeter
However, I noticed you might not have checked the contribution guide yet.
Please check it out for proper flow on how we hope to streamline the development of new features or fixes.

@midepeter
Copy link
Author

#9

@opensaucerer
Copy link
Collaborator

@midepeter My sincerest apologies for the delay on the review here....

Some breaking changes have been made to Bifrost recently and might affect your current PR.

Will you be able to update the PR so I can review again or should I make the updates for you? 🙇

@midepeter
Copy link
Author

@opensaucerer hello, alright I will look into this.

@opensaucerer
Copy link
Collaborator

@opensaucerer hello, alright I will look into this.

Thank you 🙇

@opensaucerer
Copy link
Collaborator

Hi @midepeter
Here's an update on the recent changes to bifrost's codebase. The interfaces have been updated and functions to UploadFile have been modified to take structs as input instead of an enumeration of arguments.

If you pull the latest changes, you'll notice these refactors.

If you will need help refactoring this PR, do let me know. Thank you for contributing.

@midepeter
Copy link
Author

Alright noted

@midepeter
Copy link
Author

@opensaucerer i really do apologise that i have not been so consistent with this issue but i will surely complete it.

are you going to review what i have done so far? becfore i go ahead and complete it and then test.

@opensaucerer
Copy link
Collaborator

Hi @midepeter
It's completely fine, I very much understand.
I also went away for 2 months on the project, so much work at hand.

Yeah, I reviewed the work but didn't comment because I hoped to wait on the refactor to fit the new bifrost structure.

But I can leave comments if you do want me to do that now.

@midepeter
Copy link
Author

@opensaucerer

Yes, you can leave the comments already and i will work on it. Or if you want me to refactor first then no problem

bifrost.go Outdated Show resolved Hide resolved
bifrost.go Outdated Show resolved Hide resolved
gdrive/gdrive.go Outdated Show resolved Hide resolved
gdrive/gdrive.go Outdated Show resolved Hide resolved
gdrive/gdrive.go Outdated Show resolved Hide resolved

// Config returns the Google Cloud Storage configuration.
func (g *GoogleDriveStorage) Config() *types.BridgeConfig {
return &types.BridgeConfig{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseAsync is missing and google drive doesn't use DefaultBucket

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opensaucerer

I do not understand this comment. If you could help shed more light on it a bit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sure.

One of the configurations that should be returned is UseAsync and one of the configurations currently being returned in this provider includes DefaultBucket which is not needed.

gdrive/gdrive.go Show resolved Hide resolved
gdrive/struct.go Show resolved Hide resolved
Copy link
Collaborator

@opensaucerer opensaucerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@midepeter I've added the comments. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants