-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/google drive #8
base: main
Are you sure you want to change the base?
Conversation
Thank you very much for this @midepeter |
@midepeter My sincerest apologies for the delay on the review here.... Some breaking changes have been made to Bifrost recently and might affect your current PR. Will you be able to update the PR so I can review again or should I make the updates for you? 🙇 |
@opensaucerer hello, alright I will look into this. |
Thank you 🙇 |
Hi @midepeter If you pull the latest changes, you'll notice these refactors. If you will need help refactoring this PR, do let me know. Thank you for contributing. |
Alright noted |
@opensaucerer i really do apologise that i have not been so consistent with this issue but i will surely complete it. are you going to review what i have done so far? becfore i go ahead and complete it and then test. |
Hi @midepeter Yeah, I reviewed the work but didn't comment because I hoped to wait on the refactor to fit the new bifrost structure. But I can leave comments if you do want me to do that now. |
Yes, you can leave the comments already and i will work on it. Or if you want me to refactor first then no problem |
|
||
// Config returns the Google Cloud Storage configuration. | ||
func (g *GoogleDriveStorage) Config() *types.BridgeConfig { | ||
return &types.BridgeConfig{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UseAsync
is missing and google drive doesn't use DefaultBucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this comment. If you could help shed more light on it a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sure.
One of the configurations that should be returned is UseAsync
and one of the configurations currently being returned in this provider includes DefaultBucket
which is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@midepeter I've added the comments. Thank you.
…to feat/gdrive
I made this initial push for the google drive feature.