-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user-defined labels on pvcs #591
Conversation
Signed-off-by: Simon Stumpf <simon.stumpf@hispeed.ch>
Signed-off-by: Simon Stumpf <simon.stumpf@hispeed.ch>
accidentally deleted #555, sorry for that |
Hi @simonstumpf sorry we just merged a feature in #586 which bumped the version again. Would you mind update your version? Thanks. |
Adding @prudhvigodithi to take a look here. Thanks. |
Signed-off-by: Simon Stumpf <32813906+simonstumpf@users.noreply.github.com>
Hi @peterzhuamazon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems fine for me.
Adding @prudhvigodithi to take a look on this.
Thanks.
Signed-off-by: Simon Stumpf <32813906+simonstumpf@users.noreply.github.com>
Great LGTM thanks @simonstumpf, can you please update the bottom section of the changelog file, here is the example PR. |
Signed-off-by: Simon Stumpf <32813906+simonstumpf@users.noreply.github.com>
@prudhvigodithi Added it now, thx |
Thanks I have approved the PR, we can merge once the CI checks pass. |
Thanks @simonstumpf would you mind backport the change to 1.x branch? Thanks. |
Description
Add support for user-defined labels on PVCs.
Issues Resolved
Closes #554
Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.