Address feedback

Signed-off-by: Kim Pepper <kim@pepper.id.au>
opensearch-project · Nov 13, 2024 · 46357f4 · 46357f4
1 parent a0bdb57
commit 46357f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/OpenSearch/Namespaces/AbstractNamespace.php b/src/OpenSearch/Namespaces/AbstractNamespace.php
@@ -50,7 +50,10 @@ public function __construct(Transport $transport, callable|EndpointFactoryInterf
             $endpoints = $endpointFactory;
             $endpointFactory = new LegacyEndpointFactory($endpointFactory);
         } else {
-            $endpoints = fn ($c) => $endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
+            $endpoints = function ($c) use ($endpointFactory) {
+                @trigger_error('The $endpoints property is deprecated in 2.3.2 and will be removed in 3.0.0.', E_USER_DEPRECATED);
+                return $endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
+            };
         }
         $this->endpoints = $endpoints;
         $this->endpointFactory = $endpointFactory;

diff --git a/util/template/client-class b/util/template/client-class
@@ -81,7 +81,7 @@ class Client
         } else {
             $endpoints = function ($c) {
                 @trigger_error('The $endpoints property is deprecated in 2.3.2 and will be removed in 3.0.0.', E_USER_DEPRECATED);
-                $endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
+                return $endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
             };
         }
         $this->endpoints = $endpoints;