Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-7802 Monitor PR status; notify on merge/close; timeout after 1 week #153

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

locriandev
Copy link
Contributor

@locriandev locriandev commented Sep 21, 2023

Tested with:

# Open
watch https://github.com/openshift/release/pull/43595

# Merged
watch https://github.com/openshift/assisted-installer/pull/724

# Closed
watch https://github.com/openshift/assisted-installer/pull/704

# Non existent PR
watch https://github.com/openshift/assisted-installer/pull/7042344242

# Non existent repo
watch https://github.com/openshift/assisted-installerrrrrrrrr/pull/704

# ART repo
watch https://github.com/openshift-eng/art-bot/pull/152
watch https://github.com/openshift-eng/art-bot/pull/153

# Any repo
watch https://github.com/kubernetes/kubernetes/pull/120797

Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's wait a bit with deploying, there is a few watch threads running now :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@locriandev
Copy link
Contributor Author

/lgtm

Let's wait a bit with deploying, there is a few watch threads running now :)

Shouldn't be a problem, this piece of code just calls GH api once every 5 minutes. Or shall we set a cap on watch tasks? :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from joepvd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thegreyd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@locriandev locriandev merged commit 9be3da7 into openshift-eng:master Sep 22, 2023
1 check passed
@locriandev locriandev deleted the ART-7802-watch-pr branch September 22, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants