MGMT-19360: do not monitor hosts with status installed #7030
Conversation
Performance test in stage showed that the assisted-service continued to monitor hosts even after the cluster installed. This behaviour consumes a lot of CPU, this PR disables it.
openshift-ci-robot
added
the
jira/valid-reference
|
@adriengentil: This pull request references MGMT-19360 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7030 +/- ##
==========================================
- Coverage 68.22% 68.21% -0.01%
==========================================
Files 273 273
Lines 39079 39077 -2
==========================================
- Hits 26660 26656 -4
- Misses 10007 10008 +1
- Partials 2412 2413 +1
|
openshift-ci
bot
added
size/M
|
@adriengentil: This pull request references MGMT-19360 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@adriengentil: This pull request references MGMT-19360 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @rccrdpccl @tsorya |
openshift-ci
bot
requested review from
rccrdpccl,
tsorya,
linoyaslan and
romfreiman
| @@ -14,13 +14,6 @@ import ( | |||
| "gorm.io/gorm" | |||
| ) | |||
|
|
|||
| func (m *Manager) SkipMonitoring(h *models.Host) bool { | |||
| funk.Contains(skipMonitoringStates, h.LogsInfo)) | ||
| return result | ||
| } | ||
|
|
||
| func (m *Manager) initMonitoringQueryGenerator() { |
There was a problem hiding this comment.
Looks great , do we have a unit-test for it? if yes lets push
|
@adriengentil: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Performance test in stage showed that the assisted-service continued to
monitor hosts even after the cluster installed. This behavior consumes
a lot of CPU, this PR disables it.
Also, move the logic from
SkipMonitoringfunction into the SQL query sowe avoid to retrieve hosts that we be skipped anyway (and save some
un-marshaling operations).