NO-ISSUE: Remove docker as container runtime command option #2470
Conversation
…he lack of docker support in newer skipper versions.
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@eliorerz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -3,7 +3,7 @@ | |||
| ############# | |||
|
|
|||
| SHELL=/bin/sh | |||
| CONTAINER_COMMAND := $(shell scripts/utils.sh get_container_runtime_command) | |||
There was a problem hiding this comment.
I think skipper sets this var to podman-remote
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
@eliorerz can we close this one ? |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
Due to the lack of docker support in newer skipper versions
/cc @danmanor