-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-2559: FIPS backports for MCE-2.5 4.16 installation #2344
base: mce-2.5
Are you sure you want to change the base?
Conversation
@celebdor: This pull request references HIVE-2559 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celebdor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mce-2.5 #2344 +/- ##
========================================
Coverage 57.92% 57.93%
========================================
Files 186 186
Lines 26075 26074 -1
========================================
+ Hits 15105 15106 +1
+ Misses 9707 9705 -2
Partials 1263 1263
|
As a result of the openshift installer transitioning from rhel8 to rhel9 (openshift/installer#8196), running openshift-install in the rhel8 backed hive container in order to install a cluster in fips mode results in a fips incompatibility. Create a seperate installmanager binary that runs the install-manager command previously invoked by hiveutil. Build a rhel8 and rhel9 version of hive, and copy both versions of installmanager to the installer container. The directory struture of the provisioning pod is also adjusted to support this change. Lastly, the installmanager binary corresponding to the rhel version of the installer container. Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
New builder images do not alias python to python3 Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
3192380
to
3ea4f19
Compare
@celebdor: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In order for MCE-2.5 to be able to deploy FIPS enabled spoke clusters from a FIPS enabled hub cluster, we need to backport the logic to choose the right userspace to run hiveutil/installer from