Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Drop build-machinery-go #2346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Drop build-machinery-go #2346

wants to merge 2 commits into from

Conversation

celebdor
Copy link
Contributor

@celebdor celebdor commented Jul 8, 2024

newMakefile's goals:

  • All targets explicit
  • Grouping of targets
  • Consistency in implementation
  • Install tools from vendoring where possible
  • De-duplication
  • Remove obsolete parts

@celebdor
Drop codegen k8s.io/code-generator
b60141f 
generate-groups.sh was deprecated in k8s.io/code-generator 1.29 and deleted in
1.30. Instead, the usage was replaced with:

- kube_codegen.sh library's kube::codegen::gen_helpers

The issue with the above is:

- It doesn't allow to specify just running deepcopy and instead adds as
  well code conversion and defaulter code generation.
- While deepcopy-gen and conversion-gen can deal well with the multiple
  input paths that we have, conversion-gen wants to work at the package
  level, which means it ends up wrongly processing the vendored k8s
  deepcopy directives. This in turn means that we are forced to use the
  kubernetes header files to respect their copyright, but ends up adding
  the kubernetes copyright to openshift generated code.
- gen_helpers enforces usage of --output-base matching the import name,
  which means that we had to workaround with a symlink of
  ${REPO_ROOT}/github.com/openshift/ to "${REPO_ROOT}..".
- vendored generated deepcopy got deleted and `make vendor` had to pick
  up the tab.

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@celebdor
feat(build): bmg-less Makefile
03b39ec 
This commit introduces a newMakefile that no longer uses
build-machinery-go.

The goal is that all the targets are explicit and easy to digest

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever July 8, 2024 14:47
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign suhanime for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

@celebdor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 03b39ec link true /test security
ci/prow/verify 03b39ec link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@jstuever jstuever Awaiting requested review from jstuever

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@celebdor @openshift-merge-robot @openshift-bot