Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-2656: Various fixes related to hive developer experience (dx) #2512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlom
Copy link
Contributor

@dlom dlom commented Nov 8, 2024

.gitignore: add venv so I stop accidentally adding it with git add hack/

hack/*.sh: use oc instead of kubectl

Makefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)

/assign @2uasimojo

card: HIVE-2656

@dlom
Copy link
Contributor Author

dlom commented Nov 8, 2024

/retitle HIVE-2656: Various fixes related to hive developer experience (dx)

@openshift-ci openshift-ci bot changed the title Various fixes related to hive developer experience (dx) HIVE-2656: Various fixes related to hive developer experience (dx) Nov 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@dlom: This pull request references HIVE-2656 which is a valid jira issue.

In response to this:

.gitignore: add venv so I stop accidentally adding it with git add hack/

hack/*.sh: use oc instead of kubectl

Makefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)

/assign @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@dlom: This pull request references HIVE-2656 which is a valid jira issue.

In response to this:

.gitignore: add venv so I stop accidentally adding it with git add hack/

hack/*.sh: use oc instead of kubectl

Makefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)

/assign @2uasimojo

card: HIVE-2656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@dlom: This pull request references HIVE-2656 which is a valid jira issue.

In response to this:

.gitignore: add venv so I stop accidentally adding it with git add hack/

hack/*.sh: use oc instead of kubectl

Makefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)

/assign @2uasimojo

card: HIVE-2656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

.gitignore: add venv so I stop accidentally adding it with `git add hack/`

hack/*.sh: use `oc` instead of `kubectl`

Makefile: add target for using podman to push to registry (local
registry running in podman has no security setup, hence ignore TLS)
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@dlom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-pool e8d00f1 link true /test e2e-pool

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -317,6 +317,10 @@ buildah-dev-build:
podman-dev-build:
podman build --tag ${IMG} $(GOCACHE_VOL_ARG) -f ./Dockerfile .

.PHONY: podman-dev-push
podman-dev-push: podman-dev-build
podman push --tls-verify=false ${IMG}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely +1 to having this target.

I don't think we should turn off TLS by default though. Other options:

  • Make a PODMAN_PUSH_FLAGS var so you can make PODMAN_PUSH_FLAGS=--tls-verify=false podman-dev-push when your registry is "insecure" (or whatever).
  • Configure your personal insecure registries per the man page:

If not specified, TLS verification is used unless the target registry is listed as an insecure registry in containers-registries.conf(5)

@@ -7,6 +7,7 @@
bin/**
**/__debug_bin
**/__pycache__
**/venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hate this, but it assumes everyone uses the same name for their python venv as you.

You can set up personal gitignores in several ways. For example, my ~/.gitconfig contains:

[core]
	excludesfile = /home/efried/.gitignore

...and that file contains:

.vscode/
*.orig
.sw[a-p]
.*.sw[a-p]

(The idea being that not everyone necessarily uses vscode -- though I see we've got that in here on L33 -- or vim.)

@@ -5,7 +5,7 @@
# - hiveadmission
# - hive-controllers
#
cat <<EOF | kubectl apply -f -
cat <<EOF | oc apply -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

This script is explicitly for folks setting up hive on non-openshifts.

And most of the time, people have them (sym)linked to each other anyway.

efried@efried-thinkpadp16vgen1:~/go/src/github.com/openshift/hive$ ll -i ~/bin/oc ~/bin/kubectl
2567104 -rwxr-xr-x. 2 efried efried 160441224 Jul 18 16:42 /home/efried/bin/kubectl*
2567104 -rwxr-xr-x. 2 efried efried 160441224 Jul 18 16:42 /home/efried/bin/oc*

@@ -24,7 +24,7 @@ cat <<EOF | cfssl genkey - | cfssljson -bare server
}
EOF

cat <<EOF | kubectl apply -f -
cat <<EOF | oc apply -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto (and below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants