Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-2525: privatelink: add privatelink controller unit tests #2520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jstuever
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2024

@jstuever: This pull request references HIVE-2525 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (3ccd44d) to head (b8b6a9a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
+ Coverage   46.26%   47.06%   +0.79%     
==========================================
  Files         279      281       +2     
  Lines       32913    32963      +50     
==========================================
+ Hits        15227    15513     +286     
+ Misses      16406    16167     -239     
- Partials     1280     1283       +3     
Files with missing lines Coverage Δ
.../privatelink/actuator/testactuator/testactuator.go 100.00% <100.00%> (ø)
pkg/test/clusterdeployment/clusterdeployment.go 97.32% <100.00%> (+0.07%) ⬆️
pkg/test/clusterprovision/clusterprovision.go 97.72% <100.00%> (+0.08%) ⬆️
pkg/test/logger/logger.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@jstuever jstuever changed the title HIVE-2525: privatelink: add privatelink controller unit tests WIP: HIVE-2525: privatelink: add privatelink controller unit tests Nov 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstuever jstuever changed the title WIP: HIVE-2525: privatelink: add privatelink controller unit tests HIVE-2525: privatelink: add privatelink controller unit tests Nov 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants