OpenStack: Add openstack-provision-etcd-disk-speed step #58941
Conversation
| @@ -0,0 +1,44 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This step could be shared with other platforms to avoid duplication in the future, but this seems to be a common pattern in this repo.
|
/approve |
|
/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-etcd-scaling |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
bot
added
the
approved
|
NOTE: ETCD slow profile only works from OCP 4.16 and above |
|
The results are acceptable to me. We didn't see etcd failures in e2e: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/58941/rehearse-58941-periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-etcd-scaling/1858550463058677760 |
EmilienM
force-pushed
the
openstack-etcd-slow
branch
from
f6a52ee
to
6573b7c
Compare
|
Fixed metadata, by running |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mandre
force-pushed
the
openstack-etcd-slow
branch
from
6573b7c
to
2648409
Compare
|
New changes are detected. LGTM label has been removed. |
|
/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-etcd-scaling |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
OK, the 4.18-e2e-openstack-ovn-etcd-scaling job might not be representative after all. It's running with etcd on RAMFS already and should not fail due to disk latency. According to the logs, we've successfully patched the cluster (the heartbeat interval changed to 500 as seen here) but our version check failed because we couldn't find the Looking at prow results, the 4.18 ovn-etcd-scaling jobs are very unstable on every platform. This is also the case for the 4.17 ovn-etcd-scaling jobs. The 4.16 ovn-etcd-scaling jobs are fine however. |
mandre
force-pushed
the
openstack-etcd-slow
branch
from
2648409
to
4a2c535
Compare
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This step patches the etcd cluster to configure disk speed. It defaults to being a no-op. Co-Authored-By: Miguel Carpio <mcarpio@redhat.com>
We know our OpenStack envs are slow. Let's tweak etcd to be more tolerant to disk latency.
mandre
force-pushed
the
openstack-etcd-slow
branch
from
4a2c535
to
2790e90
Compare
|
[REHEARSALNOTIFIER]
A total of 898 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-shiftstack-ci-release-4.16-e2e-openstack-ccpmso-zone |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This step patches the etcd cluster to configure disk speed. It defaults
to being a no-op.
We know our OpenStack envs are slow. Let's tweak etcd to be more
tolerant to disk latency by enabling slow profile for all OpenStack clusters.