Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-35285: Remove HNS networks before rebooting in AWS #2433

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

OCPBUGS-35285: Remove HNS networks before rebooting in AWS #2433

wants to merge 2 commits into from
+54 −4

Conversation

jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Sep 26, 2024 •
edited
Loading

This PR introduces a fix for AWS as a particular case where the EC2 Agent fails to configure the metadata endpoint when the HNS are fully configured with the virtual network interfaces.

followup-to

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@jrvaldes: This pull request references Jira Issue OCPBUGS-36305, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR introduces a fix for AWS as a particular case where the EC2 Agent fails to configure the metadata endpoint when the HNS are fully configured with the virtual network interfaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jrvaldes jrvaldes changed the title OCPBUGS-36305: Remove HNS networks before rebooting in AWS OCPBUGS-35285: Remove HNS networks before rebooting in AWS Sep 26, 2024
@openshift-ci-robot
Copy link

@jrvaldes: This pull request references Jira Issue OCPBUGS-35285, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR introduces a fix for AWS as a particular case where the EC2 Agent fails to configure the metadata endpoint when the HNS are fully configured with the virtual network interfaces.

followup-to

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@jrvaldes
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@jrvaldes: This pull request references Jira Issue OCPBUGS-35285, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@jrvaldes: This pull request references Jira Issue OCPBUGS-35285, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jrvaldes
Copy link
Contributor Author

/test aws-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes
[nodeconfig] remove HNS networks on reboot in AWS
548c371 
This commit removes the HNS networks during the safe reboot
workflow in AWS to prevent the EC2 Launch agent from deleting
the metadata routes.
@jrvaldes
[e2e] Add version anno remove test
5680e40 
This commit introduces a test to check WMCO is able to reconfigure
instances when the version annotation gets removed.
@jrvaldes
Copy link
Contributor Author

/test aws-e2e-operator

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Oct 1, 2024

/test azure-e2e-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@jrvaldes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/azure-e2e-upgrade 5680e40 link true /test azure-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrasouli rrasouli Awaiting requested review from rrasouli

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrvaldes @openshift-ci-robot