Fix running pytest in root of repo #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Minor cleanup. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Treat tests as a directory full of modules, rather than as a package. This will allow us to stop adding the root of the repo to the Python path. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
By default, running `pytest` prepends the source directory to the Python path, since that's where the `tests` package is. That causes Python to import `openslide` from the source directory instead of using the installed copy, and this fails because the source directory doesn't have the compiled extension module. Configure pytest not to change the Python path, as recommended by pytest docs: https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#choosing-an-import-mode Then, manually set the Python path to allow tests to load common code. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't test the
openslidepackage in-repo because we need to use a copy that includes the compiled extension module. But even if the package was installed into the Python path, we couldn't runpytestin the root of the repo, because theopenslidedirectory in the repo would take precedence.Configure pytest not to modify the Python path, allowing it to properly use an installed
openslidepackage. Also do some minor rearranging of tests.