Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MANIFEST.in #242

Closed
wants to merge 1 commit into from
Closed

Conversation

jaharkes
Copy link
Member

Use setuptools.package-data to indicate which files should be included in the sdist and wheel packages.

I checked the file list in the wheel before and after the patch and they matched up. The sdist file is different because it no longer has MANIFEST.in after this patch, but all other included files are still the same.

Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
@openslide-bot
Copy link

openslide-bot commented Nov 16, 2023

DCO signed off ✔️

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

@bgilbert
Copy link
Member

Thanks for the PR. Unfortunately, this doesn't actually work: the files aren't included in the source tarball when building from a fresh checkout. When rebuilding from an existing checkout, setuptools adds files from the prior openslide_python.egg-info/SOURCES.txt, which is why it seemed to work.

From the documentation, package-data is meant to specify data files for the installed package directory, not files to be included in the source tarball but not installed.

I'll go ahead and close this. There's a setuptools issue to track the necessary support: pypa/setuptools#3341

@bgilbert bgilbert closed this Nov 17, 2023
@jaharkes jaharkes deleted the remove_manifest_in branch November 17, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants