Support openslide-bin #267
Conversation
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
|
May I ask when this PR will be merged and the potential release date of openslide-python 1.4.0? |
|
Hopefully within the next couple months. The missing pieces for this PR are docs and error message updates, which don't affect the functionality, so while you're waiting you should be able to use a local OpenSlide Python build with this patch applied. |
|
I can help with the docs and the error message part if this can accelerate the release process. |
|
Thanks for the offer. 1.4.0 isn't only waiting for this PR, though. Type hints and some additional cleanups are also planned, and my attention is currently on some work in the main OpenSlide repo. If you'd like to contribute the docs and error updates, feel free to submit a new PR to this repo with just those changes. If they look good, I can merge them into this branch or land them separately. |
bgilbert
force-pushed
the
bin
branch
2 times, most recently
from
cf5574e
to
60bf607
Compare
bgilbert
force-pushed
the
bin
branch
2 times, most recently
from
d4a23fd
to
49e906b
Compare
It reads a bit better. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
bgilbert
force-pushed
the
bin
branch
2 times, most recently
from
fb35b48
to
6283e77
Compare
bgilbert
force-pushed
the
bin
branch
2 times, most recently
from
b4aeb97
to
fa9f1be
Compare
Prefer loading OpenSlide from the openslide-bin package if available. For ease of use, document openslide-bin as the preferred installation option. Don't document manual installation of openslide-bin binaries on Linux and macOS, since there isn't generally an advantage to doing that, but leave the existing Windows Zip instructions for compatibility and to explain os.add_dll_directory(). Add an explanatory ModuleNotFoundError on Linux if OpenSlide is not found. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Prefer loading OpenSlide from the openslide-bin package if available.
For ease of use, document openslide-bin as the preferred installation option. Don't document manual installation of openslide-bin binaries on Linux and macOS, since there isn't generally an advantage to doing that, but leave the existing Windows Zip instructions for compatibility and to explain
os.add_dll_directory().Add an explanatory
ModuleNotFoundErroron Linux if OpenSlide is not found.