ENG-11977 Fix logic in getModel to recognize typeless object schemas #1
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The api client generated from our openapi.json spec file (generated by the backend) had incomplete return types for some methods.
This was due to a bug in the
getModel
method, whereby if a schema definition passed in had notype
property, but was in fact anobject
(hadproperties
which implies an object), then it would "fall through" all the conditions and return an "empty" model. There was no condition to capture this edge case.As far as I can tell, the
type
property is optional, according to the OpenAPI spec, and theproperties
attribute is used to describe only objects, so its presence allows you to safely assume an object type. This logic was added to the existing object predicate, and a unit test was added to assert it.Test Plan
npm install
npm run build
npm run validate
npm run test
npm run eslint