Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the disable and enable button position #10556

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

draunger
Copy link

@draunger draunger commented Nov 25, 2024

Description

Approach

I have used position absolute property and margin property to set buttons.

Before the fix

image

After the fix

image

Attached issue

#8878

@draunger
Copy link
Author

draunger commented Dec 9, 2024

@bhousel can you review my PR and if you seems it has some issue please tell me regarding this

@bhousel
Copy link
Member

bhousel commented Dec 9, 2024

@bhousel can you review my PR and if you seems it has some issue please tell me regarding this

Using absolute positioning and a -532px margin is certainly one way to move the text, but it's not how I would do it.
What if later someone wants to change the checkboxes or the font or something.

Screenshot 2024-12-09 at 3 47 50 PM

@draunger
Copy link
Author

draunger commented Dec 10, 2024

@bhousel ok i understand then please give me some time i can change my approach
but sir one question , without applying css how we can change the position of the buttons

@bhousel
Copy link
Member

bhousel commented Dec 10, 2024

@bhousel ok i understand then please give me some time i can change my approach
but sir one question , without applying css how we can change the position of the buttons

insert them into the document where you want them to be

@draunger
Copy link
Author

draunger commented Dec 12, 2024

hey @bhousel i have changed the position of the footer without css but now it look like this but in this image map feature text and both button i.e(disable all and enable all) are not aligning in the same line.
image
if i use absolute property in map feature text css then it looks like this :
means i have apply css on the text map feature not on the buttons :
so which i use above or this ??
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants