Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Disambiguators from Relation Names in Membership Editor. Fixes #8759 #10583

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Deeptanshu-sankhwar
Copy link
Contributor

This fixes #8759

This PR improves the usability of the raw member/membership editor by removing disambiguators (text in parentheses, e.g., (Santa Clara Valley Transportation Authority)) from relation names. The change simplifies the display, making it less cluttered and more focused on relevant information like the relation's ref and primary name.

Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty reasonable for the case where a preset comes from NSI, which has a convention of using a disambiguator like this. We’ve recently also seen an example where the French localization uses a parenthetical for explanatory text in an ordinary preset name, but I think it should be fine in that case too: #10567.

In addition to the membership editor, there’s also a member editor that might need similar treatment. Consider the case where a bus stop is part of a route relation and you inspect the route relation; the list of members should label the bus stop by the truncated name too.

@Deeptanshu-sankhwar
Copy link
Contributor Author

Thanks for your feedback @1ec5 . The example of french localization shall fall within the scope of regex, so it should be fine.

For the member editor, I have made the similar regex changes such that disambiguators are now removed from both membership editor and member editor. Kindly take a look whenever you can.

Thanks!

@tyrasd tyrasd added the usability An issue with ease-of-use or design label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit disambiguator from relation type in member/membership editor
3 participants