Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] CCE: Refactor CCE Addons #2770

Merged
merged 6 commits into from
Dec 19, 2024
Merged

[Refactor] CCE: Refactor CCE Addons #2770

merged 6 commits into from
Dec 19, 2024

Conversation

muneeb-jan
Copy link
Member

@muneeb-jan muneeb-jan commented Dec 18, 2024 •
edited
Loading

Summary of the Pull Request

Apply changes from gopher in provider

PR Checklist

  • Tests added/passed.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccCCEAddonV3Basic
=== PAUSE TestAccCCEAddonV3Basic
=== RUN   TestAccCCEAddonV3CoreDNS
=== PAUSE TestAccCCEAddonV3CoreDNS
=== RUN   TestAccCCEAddonV3Flavor
=== PAUSE TestAccCCEAddonV3Flavor
=== CONT  TestAccCCEAddonV3Basic
=== CONT  TestAccCCEAddonV3CoreDNS
=== CONT  TestAccCCEAddonV3Flavor
--- PASS: TestAccCCEAddonV3CoreDNS (666.39s)
--- PASS: TestAccCCEAddonV3Flavor (734.45s)
--- PASS: TestAccCCEAddonV3Basic (769.78s)
PASS

Skipped: TestAccCCEAddonV3ForceNewCCE

@muneeb-jan muneeb-jan self-assigned this Dec 18, 2024
@muneeb-jan muneeb-jan marked this pull request as ready for review December 19, 2024 13:36
@muneeb-jan muneeb-jan added the gate Merge PR label Dec 19, 2024
@otc-zuul otc-zuul
Copy link

otc-zuul bot commented Dec 19, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/55f0db1d484945ffb093bc9e61266850

✔️ build-otc-releasenotes SUCCESS in 4m 08s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 24s
✔️ golang-make-test SUCCESS in 3m 38s
✔️ golang-make-vet SUCCESS in 2m 48s
✔️ tflint SUCCESS in 1m 55s
✔️ goreleaser-build SUCCESS in 8m 01s

@otc-zuul otc-zuul bot merged commit 6b85863 into devel Dec 19, 2024
6 checks passed
@otc-zuul otc-zuul bot deleted the refactor-cce-addons branch December 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@Aloento Aloento Awaiting requested review from Aloento

@artem-lifshits artem-lifshits Awaiting requested review from artem-lifshits

Assignees

@muneeb-jan muneeb-jan

Labels
dependencies gate Merge PR refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muneeb-jan @anton-sidelnikov