[pd] add API strings for idle state #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
===========================================
- Coverage 55.77% 45.66% -10.11%
===========================================
Files 87 100 +13
Lines 6890 11890 +5000
Branches 0 870 +870
===========================================
+ Hits 3843 5430 +1587
- Misses 3047 6170 +3123
- Partials 0 290 +290 ☔ View full report in Codecov by Sentry. |
23 tasks
| @@ -52,6 +52,7 @@ | |||
| #define OTBR_DHCP6_PD_STATE_NAME_DISABLED "disabled" | |||
| #define OTBR_DHCP6_PD_STATE_NAME_STOPPED "stopped" | |||
| #define OTBR_DHCP6_PD_STATE_NAME_RUNNING "running" | |||
| #define OTBR_DHCP6_PD_STATE_NAME_IDLE "idle" | |||
There was a problem hiding this comment.
I think this symbol is not exposed? And we have no doxgen within this file?
erjiaqing
force-pushed
the
pd/add-idle-state-string
branch
4 times, most recently
from
53685be
to
32588e9
Compare
erjiaqing
force-pushed
the
pd/add-idle-state-string
branch
from
e4301c4
to
9cafa1e
Compare
erjiaqing
force-pushed
the
pd/add-idle-state-string
branch
from
9cafa1e
to
fc67e81
Compare
jwhui
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.