Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing stop broadcast #333

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Fixing stop broadcast #333

merged 6 commits into from
Jun 11, 2024

Conversation

marinaserranomontes
Copy link
Contributor

What is this PR doing?

Fix stopBrodcast call.

How should this be manually tested?

What are the relevant tickets?

VIDECO-9803

package.json Outdated Show resolved Hide resolved
jeffswartz
jeffswartz previously approved these changes Jun 10, 2024
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package-lock.json can also be removed from this commit. No new packages/updates were done with this PR. There is also missing tests

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to have an unit test to confirm that this is resolving the issue

@manchuck manchuck merged commit 1bdd7b2 into main Jun 11, 2024
12 checks passed
@manchuck manchuck deleted the fix-stop-broadcast branch June 11, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants