GraphQL Trip Stop Sequence Support #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
approved these changes
Jun 21, 2023
| departureStoptime?: TripStopTime; | ||
| gtfsId?: string; | ||
| id: string; | ||
| tripHeadsign?: string; |
There was a problem hiding this comment.
this field and gtfsId are both required on the schema. Should we make them required here too? Just because they're required on the schema doesn't mean we have to request them in our query, so I can see it both ways.
There was a problem hiding this comment.
The data passed on this component is sometimes generated by a client instead of fed right in from OTP. Do you think it's still worth making this change? I guess those projects would then throw TS errors, which is good.
amy-corson-ibigroup
approved these changes
Jun 22, 2023
# Conflicts: # packages/types/src/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stop sequence support when using the new GraphQL API.