UCT/GGA: rkey resolution for many MDs #10236
Open
+426
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeny-leksikov
force-pushed
the
uct_gga_ep_put_get_mds_rkey
branch
from
fab25db
to
c86b266
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
iyastreb
reviewed
Nov 8, 2024
src/uct/ib/mlx5/gga/gga_mlx5.c
Outdated
| md_attr->rkey_packed_size = md_attr->exported_mkey_packed_size; | ||
| return UCS_OK; | ||
| } | ||
| static pthread_mutex_t uct_gga_mlx5_rkeys_locker = PTHREAD_MUTEX_INITIALIZER; |
There was a problem hiding this comment.
maybe use "_lock" or "_mutex" to conform with the codebase
Maybe store it in the component uct_gga_component?
There was a problem hiding this comment.
Maybe store it in the component uct_gga_component?
I also thought about it, but don't found much benefit, just more code related to new type/struct
|
|
||
| *rkey_p = (uintptr_t)rkey_handle; | ||
| *handle_p = NULL; | ||
| return UCS_OK; | ||
| } | ||
|
|
||
| static ucs_status_t | ||
| uct_gga_mlx5_md_put_rkey(uct_gga_mlx5_md_t *md, | ||
| const uct_gga_mlx5_rkey_hash_key_t key, |
There was a problem hiding this comment.
minor: since key is primitive const is redundant
There was a problem hiding this comment.
it's more for readability and clean API + uct_gga_mlx5_rkey_hash_key_t might be changed in future, so this place won't require changes
evgeny-leksikov
commented
Nov 11, 2024
iyastreb
reviewed
Nov 15, 2024
iyastreb
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rkey resolution for many MDs in GGA transport
Why ?
#9993 (comment)
How ?