UCP/WIREUP: Support reused lanes for EP reconfiguration #10244
Conversation
shasson5
added
Invalid
shasson5
changed the title
shasson5
removed
Invalid
|
@shasson5 please improve the description: |
src/ucp/core/ucp_ep.c
Outdated
| } | ||
|
|
||
| for (lane = 0; lane < key->num_lanes; lane++) { | ||
| if (ucp_ep_get_reused_lane_source(ep, lane, reuse_lane_map) == |
There was a problem hiding this comment.
There is O(n^2) complexity here, let's try to avoid it.
|
@shasson5 as discussed, please refactor the test to rely on parametrization of existing scenarios, rather then writing new test cases from scratch. |
| @@ -92,15 +103,25 @@ class test_ucp_ep_reconfig : public ucp_test { | |||
| if (sender().ucph()->num_tls <= 2) { | |||
| UCS_TEST_SKIP_R("test requires at least 2 ifaces to work"); | |||
| } | |||
|
|
|||
| check_reused_lanes_reconfigurable(); | |||
There was a problem hiding this comment.
Is it really needed in every init()?
There was a problem hiding this comment.
how else will you check if reuse_lanes can be run?
There was a problem hiding this comment.
I mean - is it needed in every type of test_ucp_ep_reconfig (every test case in this file)?
There was a problem hiding this comment.
it is required for the base class (test_ucp_ep_reconfig).
What
Support reused lanes for EP reconfiguration.
Reused lanes means lanes we don't have to reconnect, but just use them as they are.
This usecase requires special handling in the code in order to allow reconfiguration of such scenarios.
Why ?
Part of EP reconfiguration feature.