Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging and Address pre-commit updates. #2173

Closed
wants to merge 3 commits into from
Closed

Conversation

samet-akcay
Copy link
Contributor

πŸ“ Description

  • Fix packaging issue caused by pkg_resources replacement.
  • autoupdate the pre-commit and fix the issues.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

davnn and others added 3 commits July 5, 2024 13:49
remove pkg_resources imports and use packaging instead

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
remove pkg_resources imports and use packaging instead

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Fix requirement parsing issue, and pre-commit
@samet-akcay samet-akcay removed the request for review from paularamo July 5, 2024 14:53
@samet-akcay
Copy link
Contributor Author

Closing this as this will be addressed in #2164

@samet-akcay samet-akcay closed this Jul 8, 2024
@samet-akcay samet-akcay deleted the fix/packaging branch July 10, 2024 10:59
@samet-akcay samet-akcay added this to the v1.1.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants