Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Remove Upper Bound on wandb Dependency #2322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samet-akcay
Copy link
Contributor

📝 Description

This PR removes the upper bound constraint on the wandb dependency in our package. This change is necessary to resolve installation issues with Python 3.12, where the imp module has been removed.

Users attempting to install our package on Python 3.12 were encountering the following error:

ModuleNotFoundError: No module named 'imp'

This error occurs because older versions of wandb (and potentially other dependencies) were using the deprecated imp module, which has been removed in Python 3.12.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
@@ -148,6 +148,11 @@ def test_export(
# https://github.com/openvinotoolkit/anomalib/issues/1513
pytest.skip(f"{model_name} fails to convert to OpenVINO")

# TODO(samet-akcay, ashwinvaidya17): Fix this test after fixing the issue
# https://github.com/openvinotoolkit/anomalib/issues/2047
if model_name == "cs_flow" and export_type == ExportType.OPENVINO:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the logs, it looks like that the torch JIT fails. Probably wandb is changing some hook. Either case, I think skipping the torch export rather than openvino might make the test pass. However, I am not sure if onnx export is affected as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Python3.12 Installation failed
2 participants