Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Added Tests for POT and NNCF Compression Types #2438

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sky0walker99
Copy link

@sky0walker99 sky0walker99 commented Nov 26, 2024

📝 Description

-This PR addresses the missing tests for the POT (Post-Training Optimization Tool) and NNCF (Neural Network Compression Framework) features in Engine.export. This PR adds unit tests to verify the export functionality with these compression types.

  • Ensures compression_type is used only with OPENVINO export type, raising an error if violated in Engine.export

  • Added tests in test_cli to cover all compression type combinations.

  • attributes POT (Post-Training Optimization) and NNCF (Neural Network Compression Framework) to the CompressionType

  • 🛠️ Fixes [Task]: Add unit tests for Engine.export #2273

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay
Copy link
Contributor

@ashwinvaidya17, will you be able to review this?

@samet-akcay samet-akcay removed the request for review from djdameln November 26, 2024 14:17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've added a few comments

tests/integration/cli/test_cli.py Show resolved Hide resolved
src/anomalib/engine/engine.py Outdated Show resolved Hide resolved
src/anomalib/deploy/export.py Outdated Show resolved Hide resolved
…updated test_export

Signed-off-by: Haroon <106879583+sky0walker99@users.noreply.github.com>
Signed-off-by: Haroon <106879583+sky0walker99@users.noreply.github.com>
Signed-off-by: Haroon <106879583+sky0walker99@users.noreply.github.com>
Signed-off-by: Haroon <106879583+sky0walker99@users.noreply.github.com>
@sky0walker99 sky0walker99 force-pushed the unit-test/engine-export-2273 branch from b94c6c5 to c4a11d5 Compare December 2, 2024 18:19
@samet-akcay samet-akcay changed the base branch from main to feature/v2 December 2, 2024 19:43
@samet-akcay samet-akcay changed the base branch from feature/v2 to main December 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add unit tests for Engine.export
3 participants